Fix: Edit navigation links from the Extensible Site Editor Sidebar#77488
Fix: Edit navigation links from the Extensible Site Editor Sidebar#77488yyppsk wants to merge 2 commits into
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @yyppsk! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What?
Closes #77071
Implements the editing-only portion of the extensible Site Editor sidebar navigation work by allowing existing navigation items to be edited directly from list view.
This PR:
Edit linkaction to the sidebar item menu forcore/navigation-linkandcore/navigation-submenuLinkUIso existing items can be edited in a popover without switching to the canvasSee also: #77069, #75921, #76428, #77072
Why?
Today, users can reorder and remove items from the extensible Site Editor sidebar, but they cannot edit an existing navigation link from that surface. To update a link label or destination, they currently need to move back into the canvas.
That gap is tracked in #77071 and is part of the broader work in #77069. A related earlier PR, #76428, explored the same problem, but review feedback there asked for the editing behavior to stay separate from broader
suggestionsQuery/ search changes, which are better handled independently in #77072.This PR keeps the scope narrow and focused on the in-place editing experience.
How?
The implementation threads sidebar edit state through the navigation menu list view and reuses the existing
NavigationLinkUIfor existing blocks, not just newly inserted ones.More specifically, it:
Edit linkmenu item in the sidebar row actions for navigation links and submenusNavigationLinkUIso it can operate on either:The PR intentionally remains focused on editing behavior and does not broaden link suggestion/search behavior beyond this scope.
Testing Instructions
npm run wp-env status.npm run wp-env start.Navigation Linkitem.Edit linkoption appears.Edit link.Navigation Submenuitem.Edit link.Testing Instructions for Keyboard
EnterorSpace.Edit link.Enter.Esc.Navigation Submenuitem.Screenshots or screencast
Edit linkopens an in-place popover from list view with correct spacing and no canvas switchScreen.Recording.2026-04-20.at.3.08.20.PM.mov
Screen.Recording.2026-04-20.at.3.09.09.PM.mov
Use of AI Tools
This pull request involved an AI-assisted review.
All generated output was manually reviewed, validated, and adjusted before submission.