Autocomplete: Refactor useAutocomplete to use useReducer#77020
Open
Autocomplete: Refactor useAutocomplete to use useReducer#77020
Conversation
Consolidates four related useState calls (selectedIndex, filteredOptions, filterValue, autocompleter) into a single useReducer, making state transitions atomic. Derives AutocompleterUI via useMemo instead of storing it as separate state, since it's purely a function of autocompleter. Moves new types to the shared types file.
Mamaduka
commented
Apr 3, 2026
Comment on lines
+107
to
+109
| const AutocompleterUI = useMemo( | ||
| () => ( autocompleter ? getAutoCompleterUI( autocompleter ) : null ), | ||
| [ autocompleter ] |
Member
Author
There was a problem hiding this comment.
I think we can improve this further and get rid of the component factory, but it's a large refactoring on its own, so we'll handle it separately.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Apr 3, 2026
| case 'Escape': | ||
| setAutocompleter( null ); | ||
| setAutocompleterUI( null ); | ||
| dispatch( { type: 'RESET' } ); |
Member
Author
There was a problem hiding this comment.
Calling the RESET seems like a better approach here, and I couldn't spot any regressions.
|
Size Change: +124 B (0%) Total Size: 7.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c95c891. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23938399425
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR contains the following code quality improvements for the
useAutocompletehook:useStatecalls with a singleuseReducerto simplify related state updates.AutocompleterUIcomponent viauseMemoinstead of storing it in state, since it's just a function ofautocompleter. This removes the awkwardsetState(() => component)workaround needed to store a function in state.ArrowUp/ArrowDownkey handlers — they only differed in index calculation, now unified with modular arithmetic.getCompletionObject.Testing Instructions
All CI checks should pass. Autocomplete has good e2e test coverage.
Use of AI Tools
Used Claude to help me with type definitions.