Components: Fix autocomplete overlapping trigger matching#77018
Open
Components: Fix autocomplete overlapping trigger matching#77018
Conversation
dbbe0dd to
c713540
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
c713540 to
d552a14
Compare
|
Size Change: +37 B (0%) Total Size: 7.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d552a14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23937674107
|
mirka
approved these changes
Apr 3, 2026
Member
There was a problem hiding this comment.
There's a test in this file called "should select the completer with the latest trigger index" that might now be better phrased as "should prefer the rightmost matching trigger when multiple completers match", or something like that, to match the new logic. (You have better context on this though)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #61919.
The approach is mostly similar to #70400, but it's a post-refactoring PR with unit tests.
PR fixes the autocomplete matcher logic and now handles overlapping triggers.
Why?
This was working, but regressed as noted in the issue.
Testing Instructions
@helloand@@helloin a paragraph block.@hello->@completer@@hello->@@completerSnippet
Use of AI Tools
Used Claude to double-check the fix.