Autocompleters: Move and improve links search#76995
Open
Conversation
Mamaduka
commented
Apr 2, 2026
Member
Author
Mamaduka
left a comment
There was a problem hiding this comment.
I couldn't find a reason why this is part of the block-editor package, but I think moving it to editor would be better. Similar to users, post entities are WP-specific.
@youknowriad, what do you think?
| triggerPrefix: '[[', | ||
| options: async ( letters ) => { | ||
| let options = await apiFetch( { | ||
| isDebounced: true, |
Member
Author
There was a problem hiding this comment.
Somewhat unofficial API. Has been supported for years via getDefaultUseItems (#29772), but it only works for the options callback, ignored with useItems.
Not sure if we want to stabilize it and make it more official.
Contributor
There was a problem hiding this comment.
I guess we could update the docs to mention that.
| search: letters, | ||
| search: filterValue, | ||
| type: 'post', | ||
| order_by: 'menu_order', |
Member
Author
There was a problem hiding this comment.
The search endpoint doesn't support the order_by argument. See: https://developer.wordpress.org/rest-api/reference/search-results/.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -50 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e8042c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23890443304
|
Contributor
|
Indeed, this component seems misplaced given is uses apiFetch directly. |
Member
Author
|
Thanks for the confirmation, @youknowriad! Pushed changes to relocate the auto-completer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR makes the following changes to links completer:
editorpackage. It shouldn't live inblock-editor, which is meant to be WordPress-agnostic.Testing Instructions
[[.Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2026-04-02.at.10.47.15.mp4
Use of AI Tools
None.