Shortcode: Fix parsing when attribute values contain brackets#76924
Open
Shortcode: Fix parsing when attribute values contain brackets#76924
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @joelyoder, @justinsc. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Mar 31, 2026
Comment on lines
+48
to
+52
| await expect( | ||
| editor.canvas.getByRole( 'document', { | ||
| name: 'Block: Custom HTML', | ||
| } ) | ||
| ).toBeHidden(); |
Member
Author
There was a problem hiding this comment.
Conversion on trunk creates an HTML block, instead of a shortcode.
|
Size Change: +35 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e96baa6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23793561097
|
Member
Can we explain more what the divergence is and why “correctly” here involves such a divergence? If there is a problem with the PHP side, it also needs updating. In fact, if our test suites diverge it would be good to ensure the same tests exist on both sides. |
Mamaduka
commented
Mar 31, 2026
Comment on lines
+132
to
+135
| * Differences from the PHP regex: | ||
| * | ||
| * - The closing shortcode tag is captured as group 6 (used by `fromMatch`). | ||
| * - Quoted attribute values may contain `]` (e.g. `text="[Click here]"`). |
Member
Author
There was a problem hiding this comment.
@dmsnell, I've added this note regarding differences. The main one is that the quoted attributes can contain brackets. Capturing groups is mostly the same.
Member
There was a problem hiding this comment.
thanks @Mamaduka — I was speaking more of behavioral differences rather than syntax though. we know that the PCRE engine in PHP is different in slight ways from the JS engine; is this change about matching the behaviors of the PHP shortcode handling or is this diverging from how the server understands shortcodes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #8937.
PR fixes a bug with the shortcode parser when values contain brackets. I've also updated
RegExpto be more readable, similar toget_shortcode_regex().This change diverges the regex from the PHP equivalent a bit, but is required to correctly convert shortcodes.
Why?
Previously, the regex would split the shortcode at the first
]inside a quoted value, causing incorrect block conversionTesting Instructions
[my_shortcode param="foo" link_text="[Click here]" bar="baz"].This is now covered by e2e tests.
Testing Instructions for Keyboard
Same.
Use of AI Tools
Used Claude to update
RegExp, it's better at it than me. Reviewed and tested changes manually.