Core Data: Fix the list of properties persisted in autosaves#76451
Merged
Core Data: Fix the list of properties persisted in autosaves#76451
Conversation
Mamaduka
commented
Mar 12, 2026
Comment on lines
+733
to
+738
| [ | ||
| 'title', | ||
| 'excerpt', | ||
| 'content', | ||
| 'meta', | ||
| ].includes( key ) |
Member
Author
There was a problem hiding this comment.
The list to match is below. I wonder if I should extract this into a constant.
gutenberg/packages/core-data/src/actions.js
Lines 691 to 696 in f8c6fa4
Contributor
There was a problem hiding this comment.
We could. It seems we want these two lists to be always in sync. Although I'd expect this to rarely change, especially with the meta prop added.
Member
Author
There was a problem hiding this comment.
Yeah, the list is probably a final for now, so let's keep it as it is.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 8.75 MB ℹ️ View Unchanged
|
|
Flaky tests detected in c6d499a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23007607882
|
ntsekouras
approved these changes
Mar 13, 2026
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #53072.
PR updates the list of persisted properties in autosaves when it's handled as a normal save. The list should include
metaafter #53072.Why?
Just a small code quality fix.
Testing Instructions
This just affects what data is synced back to the store. I couldn't find any bugs. Our e2e test coverage should suffice.