The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: +373 B (0%)

Total Size: 8.75 MB

_{compressed-size-action}

I'll deal with those E2Es later 😄

I'll deal with those E2Es later

🤔 they all pass locally for me so far

Edit: they're all failing currently on trunk too 😓

The previous "Disconnect pattern" label (introduced in #73105) was originally intended for synced patterns only but unintentionally also applied to unsynced patterns.

I wonder if it should be considered a bug because of this being a mistake? That way it can be included in 7.0.

(thanks for addressing this btw!)

👍 👍 from my angle, I like the "detach" vernacular.

Assuming no changes, is this something that could support the pattern editing feature in 7.0? I'm looking at the claim that it reduces ambiguity in UI, creating distinction between "Edit pattern" (temporarily revealing pattern structure) and the detached forever operation 🤔

Assuming no changes

I think it could reasonably go in.

The rename itself is low-risk (just string changes + a confirmation dialog), and the increased clarity between "Edit" and "Detach" does meaningfully improve the pattern editing UX that's shipping in 7.0.

Whether you frame it as a bug fix (the unintentional application to unsynced patterns) or a UX polish for the new pattern editing flow, either way it seems like a net positive for the release.

Just my two cents though

I think the added modal makes it more of an enhancement, and you might need a thumbs up from release/project leads to include it. I'd personally be ok with it (not a lead though), but I'd like more eyes on the copy. I personally don't like the term 'editing restrictions', maybe something like 'the blocks will no longer be associated with this pattern and will be fully editable'.

If the change were only renaming disconnect to detach for unsynced patterns then I think it could be considered a bug, as #73105 was only intended to change the copy for synced patterns.

Thanks, folks!

If the change were only renaming disconnect to detach for unsynced patterns then I think it could be considered a bug, as #73105 was only intended to change the copy for synced patterns.

Good point. I can split this PR into verb revert and modal, the latter can be copy-tested and so on.

Good point. I can split this PR into verb revert and modal, the latter can be copy-tested and so on.

Split out here:

• Unsynced patterns: Rename 'Disconnect pattern' to 'Detach pattern' in context menu #75807

Flaky tests detected in 5db2944.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23124114446
📝 Reported issues:

• [Flaky Test] should move focus back to the Publish panel toggle button when canceling #76179 in /test/e2e/specs/editor/various/publish-panel.spec.js