wp-build: try without including private APIs#75460
Draft
Conversation
|
Size Change: -23 B (0%) Total Size: 3.02 MB
ℹ️ View Unchanged
|
5cb438f to
3cad846
Compare
6 tasks
youknowriad
reviewed
Feb 12, 2026
| add_action( 'wp_default_scripts', '{{PREFIX}}_register_package_scripts' ); | ||
| // Priority 9 so that the Gutenberg plugin (priority 10) can override | ||
| // these scripts with newer versions when it is active. | ||
| add_action( 'wp_default_scripts', '{{PREFIX}}_register_package_scripts', 9 ); |
Contributor
There was a problem hiding this comment.
I wonder if this means Gutenberg won't override Core anymore?
Member
Author
There was a problem hiding this comment.
In which case?
- GB active:
wp_default_scriptsat 10 in GB will override this ones, which is what fixes the problem? - GB not active: wp-build scripts are active?
Contributor
There was a problem hiding this comment.
GB active: wp_default_scripts at 10 in GB will override this ones, which is what fixes the problem?
Gutenberg runs this template as well. So I thought gutenberg will also get 9 after this PR is merged.
Member
Author
There was a problem hiding this comment.
Oh, for what does GB use this? Don't we only use client-assets.php?
Contributor
There was a problem hiding this comment.
client-assets is only for things that are not "refutal scripts or modules", overrides on top of it. Nowadays Gutenberg is almost full wp-build for its own scripts and modules.
Member
Author
There was a problem hiding this comment.
I see. So could we check if we're in the GB plugin or not?
Contributor
There was a problem hiding this comment.
I mean if there's no other way sure but I wonder if we can find a generic way to make this work.
- Gutenberg should override Core
- Plugins should not override Gutenberg, they can override Core too
Member
|
This explains a lot! We've seen all sorts of weird issues (styling, JS scripts misbehaving). Our problem is that with the latest released version of Gutenberg, WP Build pages don't load due to missing scripts. Then, with Gutenberg We got close to seeing where there the problem might be but not exactly how everything interplays: https://github.com/Automattic/jetpack/pull/47035/changes (this is just a temporary fix to get things unblocked for development). |
Contributor
|
Changing the relative priorities works. I have a draft here based on this PR that fixes it, though it adds a new value to Gutenberg's package.json and would require a new release of wp-build, so you'll probably have a more elegant fix in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Make sure wp-build's private-apis script doesn't override Gutenberg's
Why?
See #75440.
How?
Move to priority 9, before GB scripts are added.
Testing Instructions
I'm testing by rebuilding https://github.com/dhasilva/minimal-wp-build-test/tree/trunk and trying http://localhost:8888/wp-admin/tools.php?page=minimal-wp-build-test-wp-admin without GB and with GB. There seems to be an unrelated error when GB is not active.
Testing Instructions for Keyboard
Screenshots or screencast