Media Upload Modal: Try hacking in a placeholder item to flag uploading state#74838
Closed
andrewserong wants to merge 1 commit into
Closed
Media Upload Modal: Try hacking in a placeholder item to flag uploading state#74838andrewserong wants to merge 1 commit into
andrewserong wants to merge 1 commit into
Conversation
|
Flaky tests detected in c0803f6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21237943391
|
Contributor
Author
|
Closing in favour of #74965 which uses notices instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A hacky experiment exploring ideas for #74837
🚧 🚧 🚧 This PR isn't intended to land, it's simply an exploration to tease out ideas 🚧 🚧 🚧
Try injecting a placeholder item into the media upload modal while an upload is in progress.
Why?
To add a visual indicator of upload progress. Note that this approach has many downsides, not least of which is that it's just hacking in a visual state for the media thumbnail rather than canonically being an "pending" item within the DataView. But a key issues is the jumpiness once an upload completes.
But it tries out the idea.
How?
TBC
Testing Instructions
Screenshots or screencast