Leverage comctx in worker-threads package#74702
Closed
adamsilverstein wants to merge 3 commits into
Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3.06 MB ℹ️ View Unchanged
|
Replace custom RPC implementation with the worker-rpc library. This significantly reduces code complexity by leveraging an established library for message-passing between main and worker threads. Changes: - Add worker-rpc dependency to package.json - Simplify main-thread.ts to use RpcProvider - Simplify worker-thread.ts to use RpcProvider - Remove custom RPC message types from types.ts - Delete rpc.ts (replaced by worker-rpc) - Simplify findTransferables to accept arrays directly - Update all tests for new implementation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Switch from worker-rpc to comctx for RPC communication - Use comctx's defineProxy with adapters for main/worker threads - Remove transferables.ts since comctx handles transfers automatically with the transfer: true option - Update tests to use addEventListener pattern that comctx expects - Add comctx to jest transformIgnorePatterns Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use options object form for self.postMessage to satisfy TypeScript's
type checking. The direct form self.postMessage(message, transfer)
doesn't match Window.postMessage overloads, but the options form
{ transfer } works with both Window and DedicatedWorkerGlobalScope.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
Investigating the failing test(s) |
Member
Author
|
Closing in favor of #74785 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #74629
Summary
worker-rpcdependency withcomctxfor RPC communication in the worker-threads packagedefineProxywith custom adapters for main thread and worker thread communicationtransferables.tssince comctx handles automatic transfer detection withtransfer: trueoptionChanges
worker-rpc: ^0.2.0tocomctx: ^1.4.3WorkerInjectAdapterand usedefineProxyfor RPC callsWorkerProvideAdapterand usedefineProxyto expose methodscomctxtotransformIgnorePatternsTest plan
🤖 Generated with Claude Code