Skip to content

noticeStore: sync notice store types with component.#74648

Open
vipul0425 wants to merge 3 commits into
WordPress:trunkfrom
vipul0425:fix/gh-sync-notice-types
Open

noticeStore: sync notice store types with component.#74648
vipul0425 wants to merge 3 commits into
WordPress:trunkfrom
vipul0425:fix/gh-sync-notice-types

Conversation

@vipul0425

Copy link
Copy Markdown
Contributor

What?

This PR adds missing options and types in the notice store to ensure type consistency between the store and notice components.

Why?

Some notice component props and options were out of sync with the actual component interface, leading to inconsistent developer experience across the codebase

How?

This PR synchronizes the notice store types with the notice component types.

@vipul0425 vipul0425 requested a review from ajitbohra as a code owner January 15, 2026 09:28
@github-actions

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions

github-actions Bot commented Jan 15, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the [Package] Notices /packages/notices label Jan 15, 2026

@jorgefilipecosta jorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems good it synchronizes the code with this file packages/components/src/notice/types.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Notices /packages/notices

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants