Disables anchor support for the More block.#74267
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
related #74103
The More block lacks a block wrapper, so adding an HTML anchor won't assign an ID.
gutenberg/packages/block-library/src/more/save.js
Lines 12 to 14 in e39ec4d
Instead, it adds
id="more-' . $_post->ID . '".https://github.com/WordPress/wordpress-develop/blob/7c7e521e36a451a4d73238706a18976b98cd4009/src/wp-includes/post-template.php#L364
Therefore, anchor support is disabled.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast