Conversation
02b7b4e to
a6f3ba8
Compare
d18608e to
266a885
Compare
| function fixDeps( pkg ) { | ||
| /** | ||
| * esbuild-sass-plugin dynamically requires postcss-modules for CSS modules support. | ||
| */ |
There was a problem hiding this comment.
One thing I've found useful in Jetpack's monorepo is to include a URL for the upstream bug report in the comment for each block. It makes it easier to audit entries to see if they've been fixed upstream. If there's really no upstream report and I don't feel like making one myself, I explicitly comment about that to set the expectation that each block is expected to have a link.
This one might be glromeo/esbuild-sass-plugin#183, for example.
| "dependencies": { | ||
| "@wordpress/dom-ready": "file:../dom-ready", | ||
| "@wordpress/i18n": "file:../i18n" | ||
| "@wordpress/dom-ready": "workspace:../dom-ready", |
There was a problem hiding this comment.
While this works, I wonder if it would be better to do it as a version number (workspace:*) and allow pnpm to determine the path via the pnpm-workspace.yaml file.
There was a problem hiding this comment.
Yes, that is the plan. I retained the path because some workspaces in routes/ don't have the name field in package.json (see #74310), which causes problems when using workspace:*.
Take two was in #38624
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast