Tabs (experimental): apply border styles to accordion header button#74003
Tabs (experimental): apply border styles to accordion header button#74003Shekhar0109 wants to merge 0 commit intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Shekhar0109! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
5c4c019 to
61bfd1c
Compare
|
Closing this PR because the experimental Tabs / Accordion implementation Happy to rework this once the new Tabs header implementation location is |
What?
This PR updates the experimental Tabs (Accordion) block so that existing
border styles—especially border radius—are applied to the actual tab
button element instead of the heading wrapper.
Why?
Currently, border styles for experimental Tabs are applied to the heading
element rather than the clickable tab button. This leads to confusing and
unexpected visuals when users adjust border radius in the Styles panel.
Applying border styles to the button itself better matches user
expectations and improves visual consistency as part of the Tabs
stabilization work.
How?
The implementation reuses existing experimental border props and moves the
border-related styles from the heading wrapper to the accordion header
button (
accordion-content__toggle). No new attributes, controls, or blocksupports are introduced.
##Issue links
See #73932
Related to #73230
Testing Instructions
Expected result:
The tab button displays rounded corners, while the heading wrapper does not.
Testing Instructions for Keyboard
tab button without affecting keyboard interaction.