Global Styles UI: Remove unnecessary padding for Navigatior component#73810
Merged
Global Styles UI: Remove unnecessary padding for Navigatior component#73810
Conversation
d15f97a to
4f68bec
Compare
t-hamano
commented
Dec 8, 2025
Comment on lines
-13
to
-15
| .components-navigator-screen { | ||
| padding: 0; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This override should no longer be necessary.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -14 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
Contributor
|
I think I fixed some of these in a recent PR. Can you check the latest state. |
Contributor
Author
|
I resolved the code conflict in this PR, but I believe this PR is still valid. The |
ramonjd
approved these changes
Dec 8, 2025
Member
ramonjd
left a comment
There was a problem hiding this comment.
Tentative approval as the main screen padding LGTM
Left a question about child screen padding, which appear different (narrower)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
The Global Styles UI package adds padding to the
Navigator.Screencomponents without a parent selector. This will cause padding to be applied to allNavigator.Screencomponents, which is not what we want.Testing Instructions
1. Create Block Them Plugin
This is just one example, and may cause issues if the consumer is using the
Navigator.Screencomponent.2. Preferences Modal (Mobile)