Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Nov 11, 2025
Comment on lines
+222
to
+224
| await expect( | ||
| page.getByRole( 'option', { name: 'Spacer', selected: true } ) | ||
| ).toBeVisible(); |
Member
Author
There was a problem hiding this comment.
Sometimes the block is selected before autocomplete selection is finalized.
Screeenshot
| <!-- /wp:heading -->` ); | ||
|
|
||
| await pageUtils.pressKeys( 'secondary+M' ); | ||
| await editor.openDocumentSettingsSidebar(); |
Member
Author
There was a problem hiding this comment.
The tests make assertion for sidebar element, this ensure that document settings sidebar is open before assertions.
Comment on lines
+921
to
+923
| await expect( | ||
| page.getByRole( 'option', { name: 'Table', selected: true } ) | ||
| ).toBeVisible(); |
Member
Author
There was a problem hiding this comment.
Sometimes the block is selected before autocomplete selection is finalized. Not really a problem for actual users. At least I wasn't able to reproduce this manually.
Screenshot
Comment on lines
+841
to
+843
| await expect( | ||
| page.getByRole( 'option', { name: 'Image', selected: true } ) | ||
| ).toBeVisible(); |
Member
Author
There was a problem hiding this comment.
Same problem with selection.
|
Size Change: 0 B Total Size: 2.42 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71211.
Closes #41396.
PR fixes various flaky tests I noticed when reviewing PRs. I'll add inline comments for each fix.
Testing Instructions
CI checks should be green.