Conversation
mcsf
left a comment
There was a problem hiding this comment.
These media-related pieces are really fragile. I'm looking forward to when we promote this experiment to a bigger change in Core and clean up a bit in the process.
Noting here — for anyone else and for my future self — that with the dequeueing of mce-view there will remain a Backbone template sent down the wire but never used: tmpl-editor-gallery. Unfortunately, it is output by wp_print_media_templates, which we can't ignore.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Kind of aside. I wonder about the "deprecate classic block" message we see when we write something in the code editor. Why are we showing this message instead of using the HTML block directly or have a message that don't mention "classic block"? I'm thinking having unmarked html is common and doesn't necessarily mean someone was reaching for the classic block. |
Yep, I wish they were more flexible and easier to orchestrate. To handle this properly, we'll need to make some changes to core. But that's the next step, we should first remove the experiment wrapper once we're happy with how it works and test it for some time. |
It's because we want to be less abrupt in this transition. We're intentionally not fully removing the classic block, because it might be the case that someone needs it and relies on it - both with a raw HTML inside the editor, and with a |
|
While we're on the topic of messaging, I did notice a bit of UX that could be better, but I'm not sure how to improve it. One of the sentences reads:
But, if the editor is dirty, refreshing will require a save. The user may be confused to see |
|
Thanks - that's been bothering me too. How about something like this:
|
|
That could work. It's the little things. :) |
Updating in #73485, please have a look when you get a chance. |
What?
Dequeue
mce-viewwhen TinyMCE is disabled as part of the relevant experiment.Why?
There are additional scripts we can stop loading together with TinyMCE.
How?
Dequeueing if the experiment is running and we don't need TinyMCE on this page.
Testing Instructions
mce-viewscript doesn't load.<div class="notice">You can include <em>raw HTML</em> here.</div>.mce-viewis loaded as part of the TinyMCE scripts.Testing Instructions for Keyboard
Same
Screenshots or screencast
None