Skip to content

Disable TinyMCE: Bump needsClassicBlock further down#72966

Merged
tyxla merged 1 commit intotrunkfrom
fix/disable-tinymce-global-var
Nov 4, 2025
Merged

Disable TinyMCE: Bump needsClassicBlock further down#72966
tyxla merged 1 commit intotrunkfrom
fix/disable-tinymce-global-var

Conversation

@tyxla
Copy link
Copy Markdown
Member

@tyxla tyxla commented Nov 4, 2025

What?

Fixes a bug with the "Disable TinyMCE" experiment, where the needsClassicBlock global var is defined too early.

Why?

Just fixing a bug.

How?

We're moving it to admin_print_footer_scripts and adding a priority to bump it even further down.

Testing Instructions

  • Go to Gutenberg > Experiments
  • Enable the "Blocks: disable TinyMCE and Classic block" experiment
  • Start a new post that has some raw HTML in the content, like this: <div class="notice">You can include <em>raw HTML</em> here.</div>.
  • Save the post and reload the post page.
  • Verify you no longer see the error.

Testing Instructions for Keyboard

Same

Screenshots or screencast

Screenshot 2025-11-04 at 14 24 14

@tyxla tyxla requested review from mcsf and youknowriad November 4, 2025 12:24
@tyxla tyxla self-assigned this Nov 4, 2025
@tyxla tyxla requested a review from spacedmonkey as a code owner November 4, 2025 12:24
@tyxla tyxla added [Block] Classic Affects the Classic Editor Block [Type] Experimental Experimental feature or API. labels Nov 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@tyxla tyxla merged commit b27a8b8 into trunk Nov 4, 2025
42 of 43 checks passed
@tyxla tyxla deleted the fix/disable-tinymce-global-var branch November 4, 2025 13:07
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Classic Affects the Classic Editor Block [Type] Experimental Experimental feature or API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants