Skip to content

Default iAPI script modules to print in footer#72459

Merged
westonruter merged 2 commits intotrunkfrom
update/script-modules-in-footer
Oct 27, 2025
Merged

Default iAPI script modules to print in footer#72459
westonruter merged 2 commits intotrunkfrom
update/script-modules-in-footer

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Oct 18, 2025 •
edited
Loading

This is an upstream companion PR for WordPress/wordpress-develop#9867 to fix Core-63486.

The PR is currently branched off of #72449 since it depends on an update to core's WP_Script_Modules which Gutenberg trunk is currently overriding.

@westonruter westonruter added this to the Gutenberg 21.9 milestone Oct 18, 2025
@westonruter westonruter mentioned this pull request Oct 18, 2025
Closed
2 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 18, 2025

Flaky tests detected in d8006ba.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18610163471
📝 Reported issues:

@westonruter westonruter changed the base branch from update/script-module-router-options-attributes to trunk October 23, 2025 15:54
@westonruter westonruter force-pushed the update/script-modules-in-footer branch from d8006ba to 768b99b Compare October 23, 2025 15:55
@westonruter westonruter marked this pull request as ready for review October 23, 2025 15:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 23, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter added No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Oct 23, 2025
luisherranz
luisherranz approved these changes Oct 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this will worsen the TTI, but I trust you to evaluate whether the increase in LCP is worth it.

LGTM! 👍

@westonruter
Copy link
Copy Markdown
Member Author

westonruter commented Oct 27, 2025

There's a massive merge conflict after #72541. Just resolved.

@westonruter westonruter merged commit 4984b51 into trunk Oct 27, 2025
53 of 57 checks passed
@westonruter westonruter deleted the update/script-modules-in-footer branch October 27, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luisherranz luisherranz luisherranz approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Milestone

Gutenberg 21.9

Development

Successfully merging this pull request may close these issues.

2 participants

@westonruter @luisherranz