Skip to content

Fix accordion-item block spacing#72148

Closed
sidharthpandita1 wants to merge 1 commit intoWordPress:trunkfrom
sidharthpandita1:fix-accordion-block-spacing
Closed

Fix accordion-item block spacing#72148
sidharthpandita1 wants to merge 1 commit intoWordPress:trunkfrom
sidharthpandita1:fix-accordion-block-spacing

Conversation

@sidharthpandita1
Copy link
Copy Markdown
Contributor

@sidharthpandita1 sidharthpandita1 commented Oct 7, 2025

What?

Closes #72116

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin, New Block.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sidharthpandita1 <sidharthpandita@git.wordpress.org>
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Adding "layout": true does solves the problem, but the Layout panel is displayed, which isn't expected to this block:

Image

We should add the fllowing definition instead:

"layout": {
	"allowEditing": false
},

P.S. It is generally best not to omit the Why?, How?, and Testing Instructions section so that someone seeing this PR for the first time can understand what it is and be able to test it properly.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Accordion Affects the Accordion Block labels Oct 8, 2025
@sidharthpandita1
Copy link
Copy Markdown
Contributor Author

THIS PR HAS BEEN MOVE TO #72176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Accordion Affects the Accordion Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accordion Item: block spacing doesn't work.

2 participants