Fix/i18n collab sidebar strings#71973
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Shekhar0109! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
t-hamano
left a comment
There was a problem hiding this comment.
Hi @Shekhar0109, this PR seems to include unnecessary changes. Let me close this PR for now.
What?
Closes #71964
__()instead of_x()for displaying the number of replies._x()in other sections (e.g., dropdown menus) where translation context is needed.Why?
How?
_x('%s more replies', 'Show replies button')with__('%s more replies')._x()usages remain unchanged.Testing Instructions
Keyboard Testing