Skip to content

Fix/i18n collab sidebar strings#71973

Closed
Shekhar0109 wants to merge 3 commits intoWordPress:trunkfrom
Shekhar0109:fix/i18n-collab-sidebar-strings
Closed

Fix/i18n collab sidebar strings#71973
Shekhar0109 wants to merge 3 commits intoWordPress:trunkfrom
Shekhar0109:fix/i18n-collab-sidebar-strings

Conversation

@Shekhar0109
Copy link
Copy Markdown
Contributor

What?

Closes #71964

  • Updated the "show more replies" section in the comment sidebar to use __() instead of _x() for displaying the number of replies.
  • Kept _x() in other sections (e.g., dropdown menus) where translation context is needed.

Why?

  • Ensures correct localization of reply counts.
  • Maintains proper translation context for other UI elements.

How?

  • Replaced _x('%s more replies', 'Show replies button') with __('%s more replies').
  • Verified that other _x() usages remain unchanged.

Testing Instructions

  1. Open a post or page in Gutenberg.
  2. Add comments to blocks to generate replies.
  3. Verify that the "show more replies" button displays the correct count.
  4. Ensure dropdown menus and other UI elements still display correctly and translations are preserved.

Keyboard Testing

  • Navigate through the comment sidebar using only the keyboard.
  • Confirm accessibility for all interactive elements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 30, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Shekhar0109 <shekh0109@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 30, 2025
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Shekhar0109! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added the Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows label Sep 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 30, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin, New Block.
  • Labels found: First-time Contributor, [Feature] Block Commenting.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shekhar0109, this PR seems to include unnecessary changes. Let me close this PR for now.

@t-hamano t-hamano closed this Sep 30, 2025
@Shekhar0109 Shekhar0109 deleted the fix/i18n-collab-sidebar-strings branch September 30, 2025 15:14
@t-hamano t-hamano added [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting and removed Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block Comments: Audit translation strings

2 participants