Fix: normalize line endings and style issues for document-bar#71426
Fix: normalize line endings and style issues for document-bar#71426Shekhar0109 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Shekhar0109! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
What?
Closes #65238
This PR implements structural and maintainability improvements in the
document-barcomponent:index.jsandstyle.scss.<h1>) out of the command button to ensure valid HTML semantics..editor-document-bar.These changes improve code structure, semantics, and maintainability without changing functionality or the user experience.
Why?
The Document Bar previously had several technical and semantic issues:
By addressing these issues first, this PR prepares the component for further accessibility and UI improvements while keeping the codebase consistent and easier to maintain.
How?
.gitattributesto enforce LF line endings for JS and SCSS files.eslint --fixandstylelint --fixon thedocument-barpackage.index.js:<h1>is now outside the command<Button>.Testing Instructions
git fetch origin fix/panel-headings-63251 && git checkout fix/panel-headings-63251.npm run lint:jsandnpm run lint:cssto verify no errors appear.document-barcomponent renders correctly:document-barfiles have LF line endings usinggit diff --check.Accessibility
<h1>is now correctly placed outside the command button, improving semantics.CI / End-to-End Tests
Some Playwright E2E tests (command palette visibility, page creation) have failed in CI. These failures are likely unrelated to this PR because:
document-bar.Maintainers may choose to re-run the failing E2E tests if needed.