Extract completer function into matchAutocompleters#71417
Extract completer function into matchAutocompleters#71417USERSATOSHI wants to merge 4 commits intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Closing in favor of #76957. I've combined the props list in a new commit. |
What?
Solves Part of #30969
Refines Autocomplete matcher function into a separate function for better testability.
This allows the function to be tested as well as later can be compared when trying to optimize the completer.
Why?
This PR allows the completer function to be unit testable which is much less fragile and would allow to compare trade offs when trying different algorithms for performance optimization.
How?
This PR addresses this by extracting the completer into a separate function with unit tests and benchmarking script to test performance.
( Part 1 and 2 of the issue )
Testing Instructions
CI Unit tests should suffice.