Conversation
In projects using the --experimental-modules flag, the default @wordpress/scripts webpack configuration returns an array of configs instead of a single object. This change normalizes the imported config to an array, applies custom rule modifications (e.g., support for .mp3 files), and exports it back in its original format. This ensures that custom webpack overrides are compatible with both single and multi-config setups, avoiding unexpected build errors.
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @darnado! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
In projects using the
--experimental-modulesflag, the default@wordpress/scriptswebpack configuration returns an array of configs instead of a single object.This change normalizes the imported config to an array, applies custom rule modifications (e.g., support for
.mp3files), and exports it back in its original format. This ensures that custom webpack overrides are compatible with both single and multi-config setups, avoiding unexpected build errors.What?
Update webpack config override example to support both single and multiple configurations returned by
@wordpress/scripts/config/webpack.config.Why?
The current example assumes a single configuration object. However, when the
WP_EXPERIMENTAL_MODULESflag is enabled, the config returns an array. Without handling this, any custom override using the--experimental-modulesflag would throw an error.This change ensures compatibility in both scenarios.
How?
Testing Instructions
Not applicable. This change updates a documentation example. No functional testing required.
Testing Instructions for Keyboard
Not applicable. This change updates a documentation example. No functional testing required.
Screenshots or screencast
Pull.Request.mp4