Attempt to fix some intermittent E2E test failures#6971
Merged
noisysocks merged 2 commits intomasterfrom May 28, 2018
Merged
Conversation
This was referenced May 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
multi-block-selectionandmanaging-linksE2E tests seem to fail intermittently in Travis CI but always pass locally for me.My guess is that it's because we're sometimes calling asynchronous functions without waiting (using
await) for the result.It's difficult to verify that this PR fixes the issue. An 'All checks have passed' is good—but we might have just gotten lucky 🤷♂️