Chrome: Unselect blocks when opening the document settings#6936
Merged
Conversation
jasmussen
approved these changes
May 24, 2018
jasmussen
left a comment
Contributor
There was a problem hiding this comment.
Nice! Works as intended.
I can't review the code, but the experience feels right 👍 👍
gziolo
reviewed
May 24, 2018
Member
There was a problem hiding this comment.
You can use object function shorthand:
return {
openDocumentSettings() { ... },
openBlockSettings() { ... },
};ca1cc48 to
58f0a68
Compare
Member
|
@youknowriad quick question: would it be easy to re-select the previously selected block when clicking "Block" after "Document" has been clicked? |
Contributor
Author
|
@afercia We'd have to store this information somewhere, we don't have it at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6887
Testing instructions