Fix: Focus loss when “Clear” button is used in Styles > Color#69097
Open
Rishit30G wants to merge 5 commits into
Open
Fix: Focus loss when “Clear” button is used in Styles > Color#69097Rishit30G wants to merge 5 commits into
Rishit30G wants to merge 5 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…clear-button-clicked
648efaf to
941f88d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #60614
Why?
This PR is intended solve the issue that occurs when the user clicks on "Clear" in the style and the focus from the component losses resulting in stack of popovers if other options are opened
How?
This PR adds a check
!userValuetocolorValuepropTesting Instructions
In the Site Editor
Go to Styles > Colors
Change a color to something other than the default
Use the “Clear” button
Notice focus is lost (palette dropdown doesn’t close as expected or if you are using the keyboard you're nowhere near where you were)
Screenshots or screencast
Before
Screen.Recording.2025-02-06.at.7.01.34.PM.mov
After
Screen.Recording.2025-04-09.at.11.41.33.AM.mov