Skip to content

Post Terms: Removing wp_kses_post causing issue#68810

Closed
benazeer-ben wants to merge 1 commit intoWordPress:trunkfrom
benazeer-ben:post-term-color-settings
Closed

Post Terms: Removing wp_kses_post causing issue#68810
benazeer-ben wants to merge 1 commit intoWordPress:trunkfrom
benazeer-ben:post-term-color-settings

Conversation

@benazeer-ben
Copy link
Contributor

@benazeer-ben benazeer-ben commented Jan 21, 2025

What?

Fixes: #68742

Why?

The bg color of the prefix and suffix format is different from the normal display.

How?

Removing wp_kses_post which causing the issue.

As mentioned in this ticket

This probably isn't really necessary, but for consistency with the other blocks that have RichText fields and server-render those fields, I thought we could add it in. (Happy to close this out if folks think it doesn't need it).

This removal mightn't affect anything.

Testing Instructions

  • Open a post or page.
  • Insert a Post Terms block.
  • Set the Prefix to a Color from the toolbar.
  • When you look at the front you can see that the Background is not being rendered.

Screenshots or screencast

Uploading Screenshare - 2025-01-21 8_38_06 PM.mp4…

@github-actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <benazeer@git.wordpress.org>
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: kartikmehta8 <kartikmehta@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka changed the title Removing wp_kses_post causing issue Post Terms: Removing wp_kses_post causing issue Jan 22, 2025
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Post Terms Affects the Post Terms Block labels Jan 22, 2025
@shimotmk
Copy link
Contributor

shimotmk commented Feb 27, 2025 •
edited
Loading

I think this change makes sense and is a good one.
It makes it more consistent with other blocks.

I think it is necessary to solve the PHP coding standards error.

@shimotmk
Copy link
Contributor

shimotmk commented Jul 24, 2025

Hi @benazeer-ben
Can you comply with the PHP coding standards?
I'll wait a few weeks, and if it doesn't look like it will comply I'll send a follow-up PR.

@shimotmk shimotmk mentioned this pull request Jul 30, 2025
Closed
@t-hamano
Copy link
Contributor

t-hamano commented Jul 31, 2025

Based on this comment, I'm closing this PR.

@t-hamano t-hamano closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

No one assigned

Labels

[Block] Post Terms Affects the Post Terms Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Post Terms block: The color of the prefix and suffix format is different from the normal display

4 participants

@benazeer-ben @shimotmk @t-hamano @Mamaduka