Skip to content

StoryBook: Add story for BlockSettingsMenu#68702

Open
im3dabasia wants to merge 1 commit intoWordPress:trunkfrom
im3dabasia:storybook/block-settings-menu
Open

StoryBook: Add story for BlockSettingsMenu#68702
im3dabasia wants to merge 1 commit intoWordPress:trunkfrom
im3dabasia:storybook/block-settings-menu

Conversation

@im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Jan 16, 2025

Part of: #67165

What?

This PR will add story for BlockSettingsMenu in the Storybook.

Testing Instructions

  1. Run npm run storybook:dev
  2. Open the storybook on localhost
  3. Check the BlockSettingsMenu story.

Screenshots or screencast

image

@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Jan 16, 2025
@im3dabasia im3dabasia marked this pull request as ready for review January 16, 2025 13:13
@im3dabasia im3dabasia requested a review from ellatrix as a code owner January 16, 2025 13:13
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Contributor Author

Hi @t-hamano ,

I’ve created this PR to add a story for the BlockSettingsMenu component. However, the issue also emphasizes creating a story for __unstableBlockSettingsMenuFirstItem.

Since __unstableBlockSettingsMenuFirstItem is an internal component that's already used as a SlotFill within the BlockSettingsMenu story, there’s already a demonstration of it in use.

Would you suggest creating a separate story to specifically demonstrate the use of the SlotFill in a custom component?

Just wanted to clarify, since it's already being used internally in the current story.

@im3dabasia im3dabasia force-pushed the storybook/block-settings-menu branch from 8e854de to 5420fd0 Compare June 20, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants