StoryBook: Add story for ColorGradientControl#68675
StoryBook: Add story for ColorGradientControl#68675im3dabasia wants to merge 6 commits intoWordPress:trunkfrom
ColorGradientControl#68675Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @t-hamano , When you have a moment please review my PR |
7603a17 to
22457a7
Compare
t-hamano
left a comment
There was a problem hiding this comment.
Sorry for the late reply. Don't we need stories for the following three exposed components?
- __experimentalColorGradientControl
- __experimentalColorGradientSettingsDropdown
- __experimentalPanelColorGradientSettings
22457a7 to
f67ae0f
Compare
f67ae0f to
616a1c7
Compare
|
Thanks @t-hamano for the feedback I agree that adding stories for the other two components makes this much more complete. I have now added the stories for There is some redundant code in the new stories, especially since both of these components are essentially wrappers around Do you think it would be a good idea to generalize and share those parts across the three stories? Or would you prefer keeping things simple and explicit for ease of readability and understanding? Looking forward to your thoughts! |
Part of #67165
What?
This PR will add stories for
ColorGradientControlcomponent in the Storybook.Testing Instructions
Screenshots or screencast
Screen.Recording.2025-01-15.at.12.13.17.PM.mov