Adding line numbers to the code#68465
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi When I apply the PR, it breaks existing code blocks. The previous version of the block needs to be deprecated, so that the editor can prevent the error. See https://developer.wordpress.org/block-editor/reference-guides/block-api/block-deprecation/ In this PR, the line numbers are only visual, and there is no way for a screen reader user to receive information about what code is on what line. |
|
Thanks for the PR! To be honest, I am personally reluctant to move forward this PR. Here are the reasons:
The Code block already offers basic functionality like color, typography, etc. Users who want more can find a plugin that meets their needs. But this is just my opinion. |
|
Let's close this as "maybe later" - #38479 (comment). Thanks for contributing, @benazeer-ben! |
What?
Fixes: #38479
How?
Added line numbers along with the code
Testing Instructions
Screenshots or screencast
Screenshare.-.2025-01-02.6_18_20.PM.mp4