Adding block description settings in preference#68435
Adding block description settings in preference#68435benazeer-ben wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi Team, Whenever you have some time, could you please review this PR? I’d really appreciate your feedback. Thanks in advance! cc: @t-hamano @carolinan |
There was a problem hiding this comment.
Thank you for the ping.
I have tested the functionality and it is working as described.
The text strings; the label and description, also feel suitable to me.
I am personally not sure about this use case. It also hides the description of patterns and block variations, like the explanation for the grid and stack group block variations.
But since it was requested by @richtabor I will assume he still wants this change to go in.
|
Thanks for the PR, @benazeer-ben!
To be honest, I'm not sure how useful this feature would be 😅 Either way, we'll need some design feedback. @WordPress/gutenberg-design Furthermore, if we do move forward with this feature, we might want to consider whether we need a similar setup for the widget editor, which would need to implement the same functionality separately. |
Mamaduka
left a comment
There was a problem hiding this comment.
I think we should be careful when introducing similar preferences and keep WP's "Decisions, not options" philosophy in mind.
- If most block descriptions aren't helpful in the sidebar, maybe we should remove them.
- Alternatively, we could hide them when simplifying editing is enabled.
Thanks again for contributing, @benazeer-ben! For similar enhancement requests, I recommend requesting initial feedback on the issue before moving to implementation.
Thanks for the info, @Mamaduka. I will ensure to request initial feedback on any enhancement issue before proceeding with implementation. Should I close this PR? Please guide me on the next steps. |
|
Yes, let's close this for now. Thanks again, @benazeer-ben! |
What?
Fixes: #42197
How?
Added a toggle to the Appearance section in Preferences modal, which allows you to turn off block descriptions.
Testing Instructions
Show block descriptionsoption from Appearance section.Screenshots or screencast
Screenshare.-.2024-12-31.5_17_44.PM.mp4