Skip to content

Storybook: Adds story and doc for duotone-control.#68262

Open
vipul0425 wants to merge 2 commits intoWordPress:trunkfrom
vipul0425:feat/67165-duotone-control
Open

Storybook: Adds story and doc for duotone-control.#68262
vipul0425 wants to merge 2 commits intoWordPress:trunkfrom
vipul0425:feat/67165-duotone-control

Conversation

@vipul0425
Copy link
Contributor

@vipul0425 vipul0425 commented Dec 24, 2024

What?

This PR adds story for duotoneControl component.
Also it adds the readme.md and JSDoc for the same

Why?

Part of: #67165
Part of: #22891

Testing Instructions

  1. Start Storybook by running npm run storybook:dev
  2. Open Storybook at http://localhost:50240/
  3. Test the story for DuotoneControl

Screenshots or screencast

Screen.Recording.2024-12-24.at.12.46.28.PM.mov

@vipul0425 vipul0425 requested a review from ellatrix as a code owner December 24, 2024 07:18
@github-actions
Copy link

github-actions bot commented Dec 24, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@hbhalodia hbhalodia mentioned this pull request Dec 25, 2024
Open
@t-hamano t-hamano mentioned this pull request Dec 27, 2024
Closed
@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Jan 7, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Jan 7, 2025 •
edited
Loading

Thanks for the PR!

Unfortunately, this component is an internal component and we decided not to add it to Storybook for internal components (See this comment).

I will close this PR but thank you for your contribution.

I was wrong, this component is not internal.

@t-hamano t-hamano closed this Jan 7, 2025
@t-hamano t-hamano reopened this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vipul0425 @t-hamano