Skip to content

Storybook: Add BlockAlignmentMatrixControl Stories and update README#68007

Merged
t-hamano merged 6 commits intoWordPress:trunkfrom
Sukhendu2002:enhancement/block-alignment-matrix-control-story
Dec 19, 2024
Merged

Storybook: Add BlockAlignmentMatrixControl Stories and update README#68007
t-hamano merged 6 commits intoWordPress:trunkfrom
Sukhendu2002:enhancement/block-alignment-matrix-control-story

Conversation

@Sukhendu2002
Copy link
Contributor

Part of #67165

What?

This PR will add stories for BlockAlignmentMatrixControl component in the Storybook.

Testing Instructions

  1. Run npm run storybook:dev
  2. Open the storybook on http://localhost:50240/
  3. Check the BlockAlignmentMatrixControl stories.

Screenshots or screencast

image

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review December 16, 2024 07:07
@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@Sukhendu2002
Copy link
Contributor Author

Hi @t-hamano, consider this PR instead of this #67292

I have applied all the suggested changes, Feel free to take a look whenever you have time. Thanks!

@github-actions
Copy link

github-actions bot commented Dec 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I left a small suggestion at the end and it's working fine 👍

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 2d974f2 into WordPress:trunk Dec 19, 2024
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants