Storybook: Add PlainText Storybook stories#67341
Conversation
- Add Default, LongText, and WithClassName stories - Configure meta for PlainText component
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @t-hamano, I have made the necessary changes to the PR based on the general feedback provided. Additionally, I reviewed other similar PRs with requested changes and implemented those adjustments as well. Could you kindly take a look at the PR when you have a moment? Thank you! 2024-12-11.00-38-57.mp4 |
packages/block-editor/src/components/plain-text/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/plain-text/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/plain-text/stories/index.story.js
Outdated
Show resolved
Hide resolved
- Enhance prop descriptions - Fix import order in storybook.
|
Hi @t-hamano, I’ve made the suggested changes and added JSDoc as recommended. Please review and let me know if anything else is needed. 2024-12-18.10-48-54.mp4 |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the update!
One last thing: I would be happy if we could unify the following three descriptions of the value prop and the onbChange prop.
- JSDoc
- README
- Storybook
It would probably be best to unify them as follows, but what do you think?
props.value:String value of the textarea.props.onChange:Function called when the text value changes.
|
Agreed, @t-hamano. The proposed wording is clear and concise, and I’ll update it accordingly. |
Part of #67165
What?
This PR adds Storybook stories for the PlainText component to improve component documentation and testability.
Why?
Testing Instructions
npm run storybook:devScreenshots or screencast
Screen.Recording.2024-11-27.at.2.47.13.PM.mov