Storybook: Add stories for DateFormatPicker Component#67290
Storybook: Add stories for DateFormatPicker Component#67290t-hamano merged 4 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
- Removed `useEffect` and streamlined state handling. - Improved parameter descriptions and documentation. - Removed unused story variants for clarity.
|
Hi @t-hamano , I have made the necessary changes to the PR based on the general feedback provided. Additionally, I reviewed other similar PRs with requested changes and implemented those adjustments as well. Could you kindly take a look at the PR when you have a moment? Thank you! 2024-12-11.00-28-15.mp4 |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR! I only have two small suggestions, but everything works as expected 👍
packages/block-editor/src/components/date-format-picker/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/date-format-picker/stories/index.story.js
Outdated
Show resolved
Hide resolved
|
Thank you, @t-hamano, for the review! I have implemented the changes as you suggested. 
|
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
P.S. Thanks to your efforts, I was able to find two issues with this component that we will address in a follow-up 👍
- The browser's default border is applied to the
fieldsetelement - There is no space between the example text and the "Choose a format" control
Part of #67165
What?
This PR adds Storybook stories for the
DateFormatPickercomponent to improve component documentation and testability.Why?
Testing Instructions
npm run storybook:devScreencast
Screen.Recording.2024-11-26.at.9.35.24.AM.mov