Size Change: -19 B (0%)

Total Size: 1.82 MB

_{compressed-size-action}

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Thanks for looking into this @Mamaduka

As a learning opportunity for me, do I get it correctly that the ref callback will be always called (but won't do anything) even when:

• The first time the sidebar renders.
• When the broken image Notice renders.

I guess there are no big downsides with those extra calls?

Yes, this ref callback (returnFocus) will always be called when the component re-renders, but it won't return focus unless returnsFocusRef.current is true.

I guess there are no big downsides with those extra calls?

No downsides here. React already does something similar internally to assign the node to ref.current.

P.S. When ref callback has a stable reference (useCallback), it will only be called on mount/unmount or if its reference changes between renders. Here's an excellent article about avoiding effects in favor of ref callbacks.