Details block: use summary content as default label#67217
Merged
talldan merged 1 commit intoWordPress:trunkfrom Nov 22, 2024
Merged
Details block: use summary content as default label#67217talldan merged 1 commit intoWordPress:trunkfrom
talldan merged 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
approved these changes
Nov 22, 2024
Contributor
talldan
left a comment
There was a problem hiding this comment.
Code looks good to me, and tests well. Thanks for the contribution!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allows the Details block to use it's summary attribute as the block label by default, similar to the Heading block.
Why?
The Details block has a viable attribute to use as the default label, and in use cases where there are dozens on a page, it makes the List View more usable.
How?
Defines custom __experimentalLabel handler to the Details block. Unsure if the accessibility label should be prefixed with "Details. " or not, tried to match the approach of the Heading block.
Testing Instructions