Element: Fix Fragment render error on empty children#6711
Merged
Conversation
jorgefilipecosta
approved these changes
May 14, 2018
Member
There was a problem hiding this comment.
This PR looks good to me 👍
For testing purposes, I changed the paragraph save return to:
return (
<Fragment>
<RichText.Content
tagName="p"
style={ styles }
className={ className ? className : undefined }
value={ content }
/>
<Fragment>
</Fragment>
<Fragment>
Ok
</Fragment>
</Fragment>
);
In this branch, the output is the expected in master it isn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #6467
This pull request seeks to resolve an error which will be thrown by
wp.element.renderToStringwhen attempting to serialize awp.element.Fragmentwith children absent.Testing instructions:
Verify unit tests pass: