Memoize pattern objects returned from getAllowedPatterns (6.7 backport)#66162
Merged
cbravobernal merged 1 commit intowp/6.7from Oct 17, 2024
Merged
Memoize pattern objects returned from getAllowedPatterns (6.7 backport)#66162cbravobernal merged 1 commit intowp/6.7from
cbravobernal merged 1 commit intowp/6.7from
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +24 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Oct 16, 2024
Contributor
getdave
left a comment
There was a problem hiding this comment.
Thank you for wrangling this backport 🙇
In my testing I can no longer see any flashing when moving between sections.
Member
Author
|
The Performance Tests are failing even after restarting them. Is this expected for backports to |
Member
Author
|
On a closer look, it's the pattern inserter tests that are failing, so this PR is breaking something. I'll have to investigate and try to reproduce locally. |
Contributor
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
1f81a8d to
a6cb22f
Compare
|
Flaky tests detected in a6cb22f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11386075341
|
This was referenced Oct 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #66159 to the
wp/6.7branch. There were merge conflicts so the backport needs to be done manually.