Fix: Shadow styles are not removed from ServerSideRender when skipBlockSupportAttributes is true#65883
Closed
lipemat wants to merge 1 commit intoWordPress:trunkfrom
lipemat:bug-65882
Closed
Fix: Shadow styles are not removed from ServerSideRender when skipBlockSupportAttributes is true#65883lipemat wants to merge 1 commit intoWordPress:trunkfrom lipemat:bug-65882
lipemat wants to merge 1 commit intoWordPress:trunkfrom
lipemat:bug-65882
Conversation
…ckSupportAttributes is true Include "shadow" in removed block support attributes within server-side-render (#65882) Resolves issue where `skipBlockSupportAttributes` was not working for blocks with "shadow" support.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Hi @lipemat, thanks for the PR! Could you provide steps, code, screenshots, etc. to test this PR? |
Closed
2 tasks
Contributor
Author
|
Attached is a quick and dirty plugin which registers a "Double Shadow" block with the required components/configuration to demonstrate the issue.
<div tabindex="0" class="block-editor-block-list__block wp-block is-selected wp-elements-0 wp-block-create-block-double-shadow" id="block-5789359d-0f34-43fc-bbe1-2512d73762b7" role="document" aria-label="Block: Double Shadow" data-block="5789359d-0f34-43fc-bbe1-2512d73762b7" data-type="create-block/double-shadow" data-title="Double Shadow" style="box-shadow: var(--wp--preset--shadow--crisp);"><div>
<div style="box-shadow:var(--wp--preset--shadow--crisp);" class="wp-block-create-block-double-shadow">Hello, Double Shadow!
</div>
</div></div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include "shadow" in removed block support attributes within server-side-render (#65882)
Resolves issue where
skipBlockSupportAttributeswas not working for blocks with "shadow" support.