Skip to content

Scripts: Update sass and sass-loader packages#65563

Closed
jacobcassidy wants to merge 4 commits into
WordPress:trunkfrom
jacobcassidy:sass-dep-update
Closed

Scripts: Update sass and sass-loader packages#65563
jacobcassidy wants to merge 4 commits into
WordPress:trunkfrom
jacobcassidy:sass-dep-update

Conversation

@jacobcassidy

Copy link
Copy Markdown
Contributor

What?

Updates the sass and sass-loader dependencies used in @wordpress/scripts.

Why?

The older version of sass-loader is using a legacy API that is coming to end-of-life. See https://sass-lang.com/documentation/breaking-changes/legacy-js-api/.

The @wordpress/scripts build process also shows multiple warnings every time it runs when sass files exist. This update removes them.

How?

This updates the @wordpress/scripts package.json file as well as the main package.json and main package-lock.json files to use the most recent updated version of sass and sass-loader.

Testing Instructions

  1. To test the changes, add the following to a package.json file that is using @wordpress/scripts:
"overrides": {
	"sass-loader": "^16.0.2",
	"sass": "^1.79.3"
},
  1. Run: npm install
  2. Run the build process: npm run build
  3. See that no issues are reported

@github-actions

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jacobcassidy <jacobcassidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jacobcassidy jacobcassidy marked this pull request as draft September 24, 2024 04:14
@gziolo gziolo added [Tool] WP Scripts /packages/scripts [Type] Enhancement A suggestion for improvement. labels Sep 24, 2024
@gziolo gziolo added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 7, 2024
@gziolo

gziolo commented Dec 7, 2024

Copy link
Copy Markdown
Member

The older version of sass-loader is using a legacy API that is coming to end-of-life. See https://sass-lang.com/documentation/breaking-changes/legacy-js-api/.

The @wordpress/scripts build process also shows multiple warnings every time it runs when sass files exist. This update removes them.

This was fixed with #67572. Tested with @wordpress/scripts@30.6.2-next.a9f418477.0. The stable version is expected to be published to npm on Wednesday. sass could still get enforced to more recent version in @wordpress/scripts and in Gutenberg, but it would be a complex warnings as there were many deprecations introduced that need to be addressed in the project.

Do you plan to continue working on this PR?

@jacobcassidy

Copy link
Copy Markdown
Contributor Author

@gziolo I'm overloaded right now, so I don't plan to continue working on this anytime soon.

Do you want me to close the related WP PRs that I am no longer actively working on?

@gziolo

gziolo commented Dec 9, 2024

Copy link
Copy Markdown
Member

I'm overloaded right now, so I don't plan to continue working on this anytime soon.

That's fair. Thank you for helping with these efforts 🙇🏻‍♂️

I'll close this PR. Let me quickly check your other PRs to see whether we can move forward something 😄

@gziolo gziolo closed this Dec 9, 2024
@jacobcassidy jacobcassidy deleted the sass-dep-update branch April 3, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Tool] WP Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants