Fix: Logic for Highlight/text-color format availability#65530
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Nov 23, 2024
Merged
Fix: Logic for Highlight/text-color format availability#65530Mamaduka merged 1 commit intoWordPress:trunkfrom
Mamaduka merged 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
44dfefe to
3fc5785
Compare
Contributor
Author
|
Re-wrote after updating master on fork (swore I updated it beforehand). Conflict resolved. |
3fc5785 to
1f7cdb7
Compare
Mamaduka
approved these changes
Nov 22, 2024
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for fixing this bug, @dougwollison!
Previous logic showed unusable Highlight format when palette was empty and custom was disabled, and hid it when custom was enabled but palette was empty.
1f7cdb7 to
1173266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Corrects the logic for showing the text-color format, either if a palette is present or if custom colors are allowed, as expected.
Why?
Previous logic mistakenly resulted in an unusable text color UI when palette was empty and custom was false, but offered no text color UI at all if palette was empty and custom was set to true.
How?
Flipped test on allowCustomControl.
Testing Instructions
For the inverse: