Select Mode: Prevent the inbetween inserter from triggering within sections#65529
Merged
youknowriad merged 1 commit intotrunkfrom Sep 20, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Contributor
|
This fixes the issues I've been seeing :) |
mikachan
reviewed
Sep 20, 2024
packages/block-editor/src/components/block-list/use-in-between-inserter.js
Show resolved
Hide resolved
mikachan
approved these changes
Sep 20, 2024
Member
mikachan
left a comment
There was a problem hiding this comment.
Ah sorry, I think I was using the wrong mode 🤦
This is what I see in select/edit mode:
Trunk:
Screen.Recording.2024-09-20.at.16.59.44.mov
This PR:
Screen.Recording.2024-09-20.at.17.01.44.mov
In that case, I think this is working as described!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #60021
Raised in this PR #65485
What?
This PR prevents the in-between block inserter from showing up when you hover between blocks within sections. The sections only allow content changes, so inserter shouldn't show up in these sections.
Testing Instructions
1- Open 2024 front page template
2- Switch to select mode
3- Hover the area right under the "about" button.
4- No in-between inserter should show up (in trunk it does show up there)