Docs: Check if done resolving first in authors example of dataviews#65246
Docs: Check if done resolving first in authors example of dataviews#65246Shelob9 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| const { records } = useEntityRecords( 'postType', 'page', queryArgs ); | ||
| const { records,isResolving,totalItems,totalPages } = useEntityRecords( 'postType', 'page', queryArgs ); | ||
|
|
||
| if ( isResolving ){ |
There was a problem hiding this comment.
Thanks for the PR! It seems that the docs have only partial DataViews per supported property and it doesn't seem very useful to update just one of them.
Maybe it's better to add a minimal example that users can copy/paste and test.
It's been while since this PR was opened, but are you open to updating the PR to have such an example?
What?
const _fields = useMemo(() => normalizeFields(fields), [fields]);in@wordpress/dataviews/build-module/components/dataviews/index.jsWhy?
How?