Add selector for getting section root clientId#65001
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 3, 2024
|
Size Change: +434 B (+0.02%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
Contributor
Author
|
I'll rebase this so we can normalize towards a single selector. |
0482bee to
1392caf
Compare
getdave
commented
Sep 3, 2024
| getDraggedBlockClientIds, | ||
| getBlockType, | ||
| getSectionRootClientId, | ||
| isZoomOutMode, |
Contributor
Author
There was a problem hiding this comment.
This isZoomOutMode dep isn't new, just the getSectionRootClientId above.
jeryj
reviewed
Sep 3, 2024
talldan
approved these changes
Sep 4, 2024
Contributor
talldan
left a comment
There was a problem hiding this comment.
Nice change, this saves from having to pass the key around everywhere.
Tests well for me and code looks good. 👍
scruffian
approved these changes
Sep 4, 2024
Contributor
scruffian
left a comment
There was a problem hiding this comment.
This is much neater, thanks!
Mamaduka
reviewed
Sep 10, 2024
Comment on lines
+548
to
+550
| export function getSectionRootClientId( state ) { | ||
| return state.settings?.[ sectionRootClientIdKey ]; | ||
| } |
Member
There was a problem hiding this comment.
Having a JSDoc block could be helpful in the future.
Contributor
Author
There was a problem hiding this comment.
Yeh we really need to do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Normalizes access to
sectionRootClientIdto a single private selector.Why?
Designed as a "code quality" fix. We have two options for improving the privacy of this property:
No matter which option we go with we'll want to normalize access to a single selector. This PR does that.
This PR is designed to be merged after one of the above PRs has been merged.
How?
Creates a single private selector to access the
sectionRootClientId.Testing Instructions
Same as #65000. Basically "does Zoom Out mode still work" as per
trunk?Testing Instructions for Keyboard
Screenshots or screencast