fix SearchConrol icon conditional display behaviour#64922
Open
Sidsector9 wants to merge 4 commits intoWordPress:trunkfrom
Open
fix SearchConrol icon conditional display behaviour#64922Sidsector9 wants to merge 4 commits intoWordPress:trunkfrom
SearchConrol icon conditional display behaviour#64922Sidsector9 wants to merge 4 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Attempting to clarify intended behavior in #64921 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64921
What?
onCloseis not set, the search icon is always shown (for empty and non-empty field)onCloseis set, then the close icon is shown when the field is not empty, and search icon is shown when the field is empty.Why?
The
SearchControlcomponent has an icon suffix to show a magnifying lens or the close icon conditionally.But when the onClose prop is set, the lens icon is never shown, and the close icon is always shown.
How?
Nothing very complex. Just modifies basic if-else logic
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast