Experiment with contentOnly templateLock on all patterns#64628
Closed
noisysocks wants to merge 1 commit intotrunkfrom
Closed
Experiment with contentOnly templateLock on all patterns#64628noisysocks wants to merge 1 commit intotrunkfrom
noisysocks wants to merge 1 commit intotrunkfrom
Conversation
|
Size Change: -144 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
getdave
reviewed
Aug 28, 2024
|
|
||
| const onInsertPattern = useCallback( | ||
| ( blocks, patternName ) => { | ||
| if ( blocks.length === 1 && blocks[ 0 ]?.name === 'core/group' ) { |
Contributor
There was a problem hiding this comment.
@MaggieCabrera @ndiego I wonder if this is a technique we could use as a proxy for "section pattern"?
Member
There was a problem hiding this comment.
Yeah perhaps. You might want to include Cover and maybe Media & Text and Columns.
Contributor
There was a problem hiding this comment.
We have a core pattern that is just a cover block, and I think TT4 has one of those too
Member
Author
There was a problem hiding this comment.
Worth noting that not all blocks support templateLock.
Contributor
There was a problem hiding this comment.
If that's the case then we'd need to iterate through the blocks applying the correct blockEditingMode. Template Lock works well for a prototype but possible not for production ready code.
Contributor
There was a problem hiding this comment.
I've realised that we're actually looking to find the block that is acting as the root of all the blocks we conceptually consider to be "sections" on a template/post.
As a result I think it's important that we review #64544 which might give us a standardised way to compute this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick experiment to see how it feels if we add
templateLock: 'contentOnly'to all patterns.