Make Query Loop settings more intuitive with a ToggleGroup and simplified help text#63739
Conversation
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've provided some feedback on the code side, but overall it's working as expected.
As for the copy, let's continue to discuss what would be ideal.
packages/block-library/src/query/edit/inspector-controls/index.js
Outdated
Show resolved
Hide resolved
packages/block-library/src/query/edit/inspector-controls/index.js
Outdated
Show resolved
Hide resolved
|
We should also make the post type help text much simpler: "Select the type of content to display: posts, pages, or custom post types." |
|
Thanks @t-hamano and @richtabor! I fixed a small code improvement suggestion but haven't changed anything regarding the copy yet. Let's continue the discussion in #63598 and keep it as a single source of truth. Once everyone agrees there I'll apply the final version here and set the PR to review 🙌 |
|
Seems there's some consensus around this suggestion: #63598 (comment) |
@jameskoster , I don't feel like everyone agreed with this one yet 🤔 |
|
It feels like the best suggestion so far. Maybe it's worth updating the PR to give it a try? Sometimes it helps to interact with the control in-situ. It's easy to change if it doesn't feel right :) |
|
@jameskoster, yeah, makes sense 😅 pushed the changes, and here's how it looks now: queryloopinspectorcontrols.mov |
|
What do you think @richtabor ? I noticed some feedback here too: #31158 (comment). Specifically for this control, "Use template’s content selection" was suggested for the |
I don't think this particular help text assists you with understanding. What's a content selection? |
packages/block-library/src/query/edit/inspector-controls/index.js
Outdated
Show resolved
Hide resolved
packages/block-library/src/query/edit/inspector-controls/index.js
Outdated
Show resolved
Hide resolved
packages/block-library/src/query/edit/inspector-controls/index.js
Outdated
Show resolved
Hide resolved
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jameskoster
left a comment
There was a problem hiding this comment.
I think it'd be fine to land, then revise if needed further. It's certainly an improvement from trunk.
Agreed!
|
Looks good! Thank you @kmanijak Karol! |
What?
Fixes #63598.
Swap "Inherit query from template" toggle with Contents: Default | Custom toggle group.
inherit: trueinherit: falseWhy?
This control has confused users (and engineers) for a long time now. This is an attempt to make it clearer as per #63598.
How?
Replace
ToggleControlwithToggleGroupControlcomponent.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast