Skip to content

Update pattern section in core-blocks reference#63441

Closed
andizer wants to merge 1 commit intoWordPress:trunkfrom
andizer:patch-1
Closed

Update pattern section in core-blocks reference#63441
andizer wants to merge 1 commit intoWordPress:trunkfrom
andizer:patch-1

Conversation

@andizer
Copy link
Copy Markdown

@andizer andizer commented Jul 11, 2024

Discovered a small mismatch on the blocks reference. Docs about the pattern was having the contents about the core block

What?

The section about the core/pattern block was having the contents of the core/block

Why?

It fixes faulty information about the pattern block.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Discovered a small mismatch on the blocks reference. Docs about the pattern was having the contents about the core block
@github-actions
Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

2 similar comments
@github-actions
Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: andizer <andizer@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @andizer! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 11, 2024
@Mamaduka
Copy link
Copy Markdown
Member

Thanks, @andizer!

I believe these details are auto-generated from the block.json file. The block you're referring to is called "Pattern placeholder".

The "Pattern" used to be a "Reusable block".

@andizer
Copy link
Copy Markdown
Author

andizer commented Jul 11, 2024

Shame on me! I didn't look further than the first thing that looked like I was searching for. Thanks for pointing me to the right one. I won't be wrong again anytime soon, however I think it might be confusing having Pattern and Pattern Placeholder on one page.

@Mamaduka
Copy link
Copy Markdown
Member

I can see how it can be confusing. The "Pattern Placeholder" is a unique block; it's not available via Inserter and is usually used by themes. So there's no name clash in the UI.

@Mamaduka
Copy link
Copy Markdown
Member

@andizer, I'm going to close the PR.

@Mamaduka Mamaduka closed this Jul 25, 2024
@andizer andizer deleted the patch-1 branch August 5, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants